Threaded Mode | Linear Mode

bbrip · 30-12-2014, 20:35

mp3 is free the last time I checked.

Also not sure about your assumption of loosing info twice. But the would of course be to re-rip lossless if the source is still at hand.

simoncn · 30-12-2014, 21:35

(30-12-2014 20:35)bbrip Wrote: mp3 is free the last time I checked.

Also not sure about your assumption of loosing info twice. But the would of course be to re-rip lossless if the source is still at hand.

There are patents covering MP3 encoding and decoding. It is my understanding that the encoding patents are enforced quite strictly.

I think the point about lossy encoding and losing information twice is valid. I am trying to assess how much work would be required to add ogg/vorbis support to MinimServer. (Note: this should really be described as adding vorbis support rather than adding ogg support.) There are some unusual aspects of vorbis that make this somewhat tricky. As an example, computing the track duration (see this post) seems to require reading the entire file to locate the last page.

tarnkappe · 31-12-2014, 15:27

This sounds complicated. Do you implement vorbis handling yourself or wouldn't you prefer to use an existing library for this?

I do not know if these libs are good, but the first hits in google are:
https://github.com/Gagravarr/VorbisJava
https://code.google.com/p/jvorbiscomment/

Greetings
Gert

tarnkappe · 31-12-2014, 15:38

Also there are some libs that decode vorbis, too. Maybe this could lead into vorbis minimstreamer support? (But this was secondary for me.)

http://www.jcraft.com/jorbis/
http://www.javazoom.net/vorbisspi/vorbisspi.html
http://www.jcraft.com/jorbis/

(Well I am not sure why I post these links here. I am sure you have already found them. But I really would like to help with this project.)

simoncn · 31-12-2014, 16:19

(31-12-2014 15:27)tarnkappe Wrote: This sounds complicated. Do you implement vorbis handling yourself or wouldn't you prefer to use an existing library for this?

I do not know if these libs are good, but the first hits in google are:
https://github.com/Gagravarr/VorbisJava
https://code.google.com/p/jvorbiscomment/

Greetings
Gert

Thanks for these links!

I have written my own code to read the audio information from all supported file formats. This helps me understand the file format as well as reducing the need to deal with external dependencies.

The first link you posted contains a tool that could be useful for showing the contents of an ogg/vorbis file for debugging purposes. The second only supports reading comments and I already have code that does this for FLAC files.

simoncn · 31-12-2014, 16:23

(31-12-2014 15:38)tarnkappe Wrote: Also there are some libs that decode vorbis, too. Maybe this could lead into vorbis minimstreamer support? (But this was secondary for me.)

http://www.jcraft.com/jorbis/
http://www.javazoom.net/vorbisspi/vorbisspi.html
http://www.jcraft.com/jorbis/

(Well I am not sure why I post these links here. I am sure you have already found them. But I really would like to help with this project.)

Thanks for these as well. Another option for decoding the audio data would be to use ffmpeg/avconv.

simoncn · 12-01-2015, 10:30

Support for reading Ogg/Vorbis files is now available in MinimServer update 56.

tarnkappe · 12-01-2015, 11:30

Wow, great news! This feels like it is christmas today. I will test it this evening when back home. This deserves a big donation...

Thank you, Simon
Gert

tarnkappe · 13-01-2015, 07:54

I tested the new version yesterday and it works fine. The server restart after the upgrade via minimwatch did not scan the ogg files, I had to trigger it manually again (I used BubbleUPnP for this). It took some minutes to scan all the ogg files. After this all files I have tried were delivered correctly.

Thank you again for this (for me very important) feature and please find the donation I have just submitted.
Gert

simoncn · 13-01-2015, 08:13

(13-01-2015 07:54)tarnkappe Wrote: I tested the new version yesterday and it works fine. The server restart after the upgrade via minimwatch did not scan the ogg files, I had to trigger it manually again (I used BubbleUPnP for this). It took some minutes to scan all the ogg files. After this all files I have tried were delivered correctly.

Thank you again for this (for me very important) feature and please find the donation I have just submitted.
Gert

You need to select Rescan from the minim icon (or from BubbleUPnP) to do a rescan. The automatic relaunch after an update does a restart without rescanning because applying an update wouldn't normally require your files to be rescanned.

The scanning overhead is a one-time operation. The audio information about your .ogg files is now in the MinimServer cache and the files won't be scanned again unless they are changed (for example, if any tags are updated).

Thanks very much for the donation!