Room correction with convolution per sample rate

[digimuse]

Simon - thank you for your clarifications.

Quote:To support your use case, the simplest solution would be to change 2) above and support the equivalent of input type filters (see this section) for selecting between different convOut option strings based on the sample rate of the input file. This would only work correctly if convolution happens prior to upsampling. I don't have an easy way to test this. Would you be able to test the combination of convolution and upsampling to check whether this assumption is correct? If the assumption is correct, would this proposed solution meet your needs?

I am mainly interested in room correction (separate filters for each sample rate), and not upsampling.

I had considered upsampling as a way to only use a single convolution filter. I see that this will not work with MinimServer if convolution is done before upsampling (in JRiver upsampling is done before convolution).

I looked at the link (Input type filters). Isn't this only for stream.transcode options?
"The filtered transcoding settings are processed first and are checked for a match in the order that they appear in the stream.transcode property. "

I thought I need to specify convolution filters in stream.options (convolution with acourate fir filter).

Maybe you were considering extending "Input Filters" to stream.options? This should work for me, as I am not interested in upsampling. It should also be more efficient to only do a single convolution based on input filters, instead of upsampling everything to 384 kHz and then applying a 384 kHz convolution filter.

Perhaps you only want to consider doing this if MinimServer currently processes convolutions first and then upsamples. I'm not sure how I could test the order in which convolution and upsampling are done by MinimServer.

Test:
44.1 kHz source
stream.transcode: flac:wav24;384
stream.options: convOut=-i /mnt/disk1/share/MinimServer/convolution/Cor1S384.wav -lavfi afir

If upsampling is done before convolution, this would be the correct result:
44.1 kHz -> upsampled to 384 kHz -> 384 kHz room correction

If convolution is done first, I'm not sure how "wrong" this should sound:
44.1 kHz -> 384 kHz room correction -> upsampled to 384 kHz

I'm not sure what other test I could do to compare with this to determine the order of convolution/upsampling.