Some Albums are not detected

[simoncn]

(08-04-2016 18:52)asiufy Wrote:  Again, seems far easier for the developers to just allow these files to go through, maybe with a warning in the log.

This depends on what kind of format error is causing the problem.

There is one specific (and common) case where MinimServer could produce a warning and attempt to recover from a format error. This is the case of a form size field that extends past the end of file. For this specific case, MinimServer could produce a warning and make an internal adjustment of the form size so that it matches the file length. This could cause problems if the form size is correct and the file has been truncated but these problems should be picked up by other checks within the MinimServer file reading code.

With this change, the log would still contain a message for each file that has this format error but it would be a warning instead of an error. Changing it to a warning means that the file would be processed instead of being ignored.

Ther would be no change to other error messages for file format errors as it is difficult to recover from these and continue reading the file.

A couple of points to note: There is a good chance that this change would allow files ripped by XLD to be processed by MinimServer but I can't be certain without having seen the faulty files. Also, MinimServer would not change the form size in the file, so the incorrect form size would be sent to the renderer and it is possible (but unlikely) that this might cause some renderers to have a problem with playing the file.

What do people think of this proposal?